Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cfa single partners cms #585

Merged
merged 14 commits into from
Sep 21, 2023
Merged

Feature/cfa single partners cms #585

merged 14 commits into from
Sep 21, 2023

Conversation

koechkevin
Copy link
Contributor

@koechkevin koechkevin commented Sep 14, 2023 •
edited
Loading

Description

This PR

  • Migrates Single partners page to CMS
  • Implements pagify for single page view

Fixes #582

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Screenshots

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@koechkevin koechkevin self-assigned this Sep 14, 2023
@koechkevin koechkevin marked this pull request as draft September 14, 2023 12:48
@github-actions
Copy link
Contributor

Latest updated Preview URL

Name Review
codeforafrica-ui-pr-585 Visit

@koechkevin koechkevin marked this pull request as ready for review September 15, 2023 13:34
kilemensi
kilemensi reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

apps/codeforafrica/src/components/ConnectBar/ConnectBar.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/components/SinglePartner/SinglePartner.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/lib/data/common/index.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/collections/Partners.js Outdated Show resolved Hide resolved
@kilemensi
Copy link
Member

Your review @kelvinkipruto

kelvinkipruto
kelvinkipruto approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@kelvinkipruto kelvinkipruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelvinkipruto
Copy link
Contributor

@koechkevin Update the Partners block preview image

@koechkevin
Copy link
Contributor Author

@koechkevin Update the Partners block preview image

https://codeforafrica-ui-pr-585.dev.codeforafrica.org/about

@kelvinkipruto
Copy link
Contributor

@koechkevin Update the Partners block preview image

https://codeforafrica-ui-pr-585.dev.codeforafrica.org/about

@Koech I meant the image preview in the CMS similar to

ui/apps/codeforafrica/src/payload/blocks/CustomPageHeader.js

Line 5 in 35caf0d

imageURL: "/images/cms/blocks/custom_page_header.jpg",

kilemensi
kilemensi reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

There is our partners on homepage and our partners on about page. How are we handling these?

apps/codeforafrica/src/components/AboutChildPageHeader/AboutChildPageHeader.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/components/SinglePartner/SinglePartner.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/lib/data/blockify/index.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/lib/data/pagify/index.js Show resolved Hide resolved
apps/codeforafrica/src/payload/blocks/OurPartners.js Outdated Show resolved Hide resolved
@koechkevin
Copy link
Contributor Author

👍🏽

There is our partners on homepage and our partners on about page. How are we handling these?

@kilemensi My thinking is, users can add a block on each page and select from a list of partners(collection) to show.

@kilemensi
Copy link
Member

👍🏽
There is our partners on homepage and our partners on about page. How are we handling these?

@kilemensi My thinking is, users can add a block on each page and select from a list of partners(collection) to show.

We have this function for that @koechkevin

@koechkevin koechkevin merged commit 59d0067 into develop Sep 21, 2023
4 checks passed
@koechkevin koechkevin deleted the feature/cfa-single-partners-cms branch September 21, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelvinkipruto kelvinkipruto kelvinkipruto approved these changes

@kilemensi kilemensi kilemensi approved these changes

Assignees

@koechkevin koechkevin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koechkevin @kilemensi @kelvinkipruto